Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 968253002: Fix missing SB2DatabaseFailure histogram entries (Closed)

Created:
5 years, 9 months ago by gab
Modified:
5 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing SB2DatabaseFailure histogram entries Also fix some mislabelled entries in the histogram enum. Make the declaration site explicit to decrease the likelihood of such omissions/mislabels happening again in the future. BUG=None Committed: https://crrev.com/71e1f811453fb04379d003d3d92d657e72a2030c Cr-Commit-Position: refs/heads/master@{#318893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -64 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_database.h View 1 chunk +38 lines, -37 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +35 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
gab
Matt/Alexei PTAL, fixed issue observed by Alexei @ https://codereview.chromium.org/611603002/diff/340001/chrome/browser/safe_browsing/safe_browsing_database.h#newcode275
5 years, 9 months ago (2015-03-02 17:13:10 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 9 months ago (2015-03-02 17:40:33 UTC) #3
mattm
lgtm
5 years, 9 months ago (2015-03-02 22:32:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968253002/1
5 years, 9 months ago (2015-03-03 13:12:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 16:37:23 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 16:38:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71e1f811453fb04379d003d3d92d657e72a2030c
Cr-Commit-Position: refs/heads/master@{#318893}

Powered by Google App Engine
This is Rietveld 408576698