Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: services/dart/test/echo/main.dart

Issue 968243003: Dart: Adds optional named arguments for creating bindings. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Format Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/dart/test/echo/main.dart
diff --git a/services/dart/test/echo/main.dart b/services/dart/test/echo/main.dart
index 1059221b9d13a02ea2d19b0cfda58b900e950f8c..5d32fb2bff9cfe9c2e5c760c64a058b2c69bdd52 100644
--- a/services/dart/test/echo/main.dart
+++ b/services/dart/test/echo/main.dart
@@ -14,16 +14,13 @@ class EchoServiceImpl implements EchoService {
Application _application;
EchoServiceImpl(Application application, MojoMessagePipeEndpoint endpoint)
- : _application = application {
- _stub = new EchoServiceStub.fromEndpoint(endpoint)
- ..delegate = this
- ..listen();
+ : _application = application {
+ _stub = new EchoServiceStub.fromEndpoint(endpoint, impl: this);
}
echoString(String value, Function responseFactory) {
if (value == "quit") {
_stub.close();
- _application.close();
}
return new Future.value(responseFactory(value));
}
@@ -34,9 +31,10 @@ class EchoApplication extends Application {
@override
void acceptConnection(String requestorUrl, String resolvedUrl,
- ApplicationConnection connection) {
- connection.provideService(EchoServiceName, (endpoint) =>
- new EchoServiceImpl(this, endpoint));
+ ApplicationConnection connection) {
+ connection.provideService(
+ EchoServiceName,
+ (endpoint) => new EchoServiceImpl(this, endpoint));
connection.listen();
}
}
« no previous file with comments | « mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl ('k') | services/dart/test/pingpong/main.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698