Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: mojo/public/dart/src/proxy.dart

Issue 968243003: Dart: Adds optional named arguments for creating bindings. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Format Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/dart/src/event_stream.dart ('k') | mojo/public/dart/src/stub.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/dart/src/proxy.dart
diff --git a/mojo/public/dart/src/proxy.dart b/mojo/public/dart/src/proxy.dart
index f7c770f661eec75e183809e3249d5f7e2b0614f2..6b00cd793bba289504f84a44ac9ef54b09a704fc 100644
--- a/mojo/public/dart/src/proxy.dart
+++ b/mojo/public/dart/src/proxy.dart
@@ -8,17 +8,19 @@ abstract class Proxy extends core.MojoEventStreamListener {
Map<int, Completer> _completerMap;
int _nextId = 0;
- Proxy(core.MojoMessagePipeEndpoint endpoint) :
- _completerMap = {},
- super(endpoint);
+ Proxy.fromEndpoint(core.MojoMessagePipeEndpoint endpoint, {bool doListen:
+ true, Function onClosed})
+ : _completerMap = {},
+ super.fromEndpoint(endpoint, doListen: doListen, onClosed: onClosed);
- Proxy.fromHandle(core.MojoHandle handle) :
- _completerMap = {},
- super.fromHandle(handle);
+ Proxy.fromHandle(core.MojoHandle handle, {bool doListen: true,
+ Function onClosed})
+ : _completerMap = {},
+ super.fromHandle(handle, doListen: doListen, onClosed: onClosed);
- Proxy.unbound() :
- _completerMap = {},
- super.unbound();
+ Proxy.unbound()
+ : _completerMap = {},
+ super.unbound();
void handleResponse(ServiceMessage reader);
@@ -46,16 +48,16 @@ abstract class Proxy extends core.MojoEventStreamListener {
}
var header = new MessageHeader(name);
var serviceMessage = message.serializeWithHeader(header);
- endpoint.write(serviceMessage.buffer,
- serviceMessage.buffer.lengthInBytes,
- serviceMessage.handles);
+ endpoint.write(
+ serviceMessage.buffer,
+ serviceMessage.buffer.lengthInBytes,
+ serviceMessage.handles);
if (!endpoint.status.isOk) {
throw "message pipe write failed - ${endpoint.status}";
}
}
- Future sendMessageWithRequestId(
- Struct message, int name, int id, int flags) {
+ Future sendMessageWithRequestId(Struct message, int name, int id, int flags) {
if (!isOpen) {
listen();
}
@@ -65,9 +67,10 @@ abstract class Proxy extends core.MojoEventStreamListener {
var header = new MessageHeader.withRequestId(name, flags, id);
var serviceMessage = message.serializeWithHeader(header);
- endpoint.write(serviceMessage.buffer,
- serviceMessage.buffer.lengthInBytes,
- serviceMessage.handles);
+ endpoint.write(
+ serviceMessage.buffer,
+ serviceMessage.buffer.lengthInBytes,
+ serviceMessage.handles);
if (!endpoint.status.isOk) {
throw "message pipe write failed - ${endpoint.status}";
}
« no previous file with comments | « mojo/public/dart/src/event_stream.dart ('k') | mojo/public/dart/src/stub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698