Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: mojo/dart/test/interface_test.dart

Issue 968243003: Dart: Adds optional named arguments for creating bindings. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Format Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/test/bindings_generation_test.dart ('k') | mojo/dart/test/validation_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/test/interface_test.dart
diff --git a/mojo/dart/test/interface_test.dart b/mojo/dart/test/interface_test.dart
index ca34dcca63fe6deb30e7974a502072095220b85a..18c47331bb870d58c6242acf779a10356c95a477 100644
--- a/mojo/dart/test/interface_test.dart
+++ b/mojo/dart/test/interface_test.dart
@@ -78,7 +78,8 @@ const int kEchoString_name = 0;
const int kEchoStringResponse_name = 1;
class EchoStub extends bindings.Stub {
- EchoStub(core.MojoMessagePipeEndpoint endpoint) : super(endpoint);
+ EchoStub(core.MojoMessagePipeEndpoint endpoint)
+ : super.fromEndpoint(endpoint);
Future<EchoStringResponse> echoString(EchoString es) {
var response = new EchoStringResponse();
@@ -110,7 +111,9 @@ class EchoStub extends bindings.Stub {
class EchoProxy extends bindings.Proxy {
- EchoProxy(core.MojoMessagePipeEndpoint endpoint) : super(endpoint);
+ EchoProxy(core.MojoMessagePipeEndpoint endpoint, {bool doListen: true,
+ Function onClosed})
+ : super.fromEndpoint(endpoint, doListen: doListen, onClosed: onClosed);
Future<EchoStringResponse> echoString(String a) {
// compose message.
@@ -140,8 +143,7 @@ class EchoProxy extends bindings.Proxy {
void providerIsolate(core.MojoMessagePipeEndpoint endpoint) {
- var provider = new EchoStub(endpoint);
- provider.listen();
+ new EchoStub(endpoint);
}
@@ -193,12 +195,10 @@ Future<bool> runOnClosedTest() async {
var testCompleter = new Completer();
var pipe = new core.MojoMessagePipe();
- var proxy = new EchoProxy(pipe.endpoints[0]);
- await Isolate.spawn(closingProviderIsolate, pipe.endpoints[1]);
- proxy.listen(onClosed: () {
+ var proxy = new EchoProxy(pipe.endpoints[0], onClosed: () {
testCompleter.complete(true);
});
-
+ await Isolate.spawn(closingProviderIsolate, pipe.endpoints[1]);
return testCompleter.future.timeout(
new Duration(seconds: 1),
onTimeout: () => false);
« no previous file with comments | « mojo/dart/test/bindings_generation_test.dart ('k') | mojo/dart/test/validation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698