Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: services/dart/test/echo/main.dart

Issue 968243003: Dart: Adds optional named arguments for creating bindings. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Binding -> Stub, delegate -> impl Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/dart/test/echo/main.dart
diff --git a/services/dart/test/echo/main.dart b/services/dart/test/echo/main.dart
index 4f93a7aae454e4aed94e1a3c49c49e16c7d65af0..85ed5e226801cada9328c60ba70428b128e1efc8 100644
--- a/services/dart/test/echo/main.dart
+++ b/services/dart/test/echo/main.dart
@@ -15,15 +15,12 @@ class EchoServiceImpl implements EchoService {
EchoServiceImpl(Application application, MojoMessagePipeEndpoint endpoint)
: _application = application {
- _stub = new EchoServiceStub.fromEndpoint(endpoint)
- ..delegate = this
- ..listen();
+ _stub = new EchoServiceStub.fromEndpoint(endpoint, impl: this);
}
echoString(String value, Function responseFactory) {
if (value == "quit") {
_stub.close();
- _application.close();
}
return new Future.value(responseFactory(value));
}
@@ -32,7 +29,9 @@ class EchoServiceImpl implements EchoService {
class EchoApplication extends Application {
EchoApplication.fromHandle(MojoHandle handle) : super.fromHandle(handle);
- void acceptConnection(String requestorUrl, ApplicationConnection connection) {
+ void acceptConnection(String requestorUrl,
+ ApplicationConnection connection,
+ String resolvedUrl) {
connection.provideService(EchoServiceName, (endpoint) =>
new EchoServiceImpl(this, endpoint));
connection.listen();

Powered by Google App Engine
This is Rietveld 408576698