Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: sky/framework/embedder.dart

Issue 968243003: Dart: Adds optional named arguments for creating bindings. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/framework/embedder.dart
diff --git a/sky/framework/embedder.dart b/sky/framework/embedder.dart
index 5c62b7a2f620b5ac77fbc01f38df3f2c6cc89c79..6f70f1b31116e7345e4fbde429293ad988eabf16 100644
--- a/sky/framework/embedder.dart
+++ b/sky/framework/embedder.dart
@@ -26,7 +26,7 @@ class _EmbedderImpl {
var proxyHandle =
new core.MojoHandle(internals.takeServicesProvidedByEmbedder());
_connection = new ApplicationConection(
- stubHandle.isValid ? new ServiceProviderStub.fromHandle(stubHandle) : null,
+ stubHandle.isValid ? new ServiceProviderBinding.fromHandle(stubHandle) : null,
proxyHandle.isValid ? new ServiceProviderProxy.fromHandle(proxyHandle) : null);
}
return _connection;
@@ -34,9 +34,9 @@ class _EmbedderImpl {
ApplicationConnection connectToApplication(String url) {
var proxy = new ServiceProviderProxy.unbound();
- var stub = new ServiceProviderStub.unbound();
- shell.ptr.connectToApplication(url, proxy, stub);
- return new ApplicationConnection(stub, proxy);
+ var binding = new ServiceProviderBinding.unbound();
hansmuller1 2015/03/02 20:42:18 Calling the stub class a "binding" has its merits.
+ shell.ptr.connectToApplication(url, proxy, binding);
+ return new ApplicationConnection(binding, proxy);
}
void connectToService(String url, bindings.ProxyBase proxy) {

Powered by Google App Engine
This is Rietveld 408576698