Dart: Adds optional named arguments for creating bindings.

mojo/public/dart/src/application_connection.dart

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 part of application;
 
 typedef Object ServiceFactory(core.MojoMessagePipeEndpoint endpoint);
 typedef void FallbackServiceFactory(String interfaceName,
     core.MojoMessagePipeEndpoint endpoint);
 
 
 class LocalServiceProvider implements ServiceProvider {
   final ApplicationConnection connection;
-  ServiceProviderStub _stub;
+  ServiceProviderBinding _binding;

[sky, 2015/03/02 20:28:22]

Binding is such a better name than Stub. Thanks!

[zra, 2015/03/02 20:52:45]

No problem =)

 
-  LocalServiceProvider(this.connection, this._stub) {
-    _stub.delegate = this;
+  LocalServiceProvider(this.connection, this._binding) {
+    _binding.delegate = this;
   }
 
-  listen() => _stub.listen();
+  listen({Function onClosed}) => _binding.listen(onClosed: onClosed);
 
-  void close({bool nodefer : false}) => _stub.close(nodefer: nodefer);
+  void close({bool nodefer : false}) => _binding.close(nodefer: nodefer);
 
   void connectToService(String interfaceName,
       core.MojoMessagePipeEndpoint pipe) {
     if (connection._nameToServiceFactory.containsKey(interfaceName)) {
       connection._nameToServiceFactory[interfaceName](pipe);
       return;
     }
     if (connection.fallbackServiceFactory != null) {
       connection.fallbackServiceFactory(interfaceName, pipe);
       return;
@@ skipping 24 matching lines @@
 //
 // The fallbackServiceFactory is only used if a service wasn't specified
 // with provideService().
 
 class ApplicationConnection {
   ServiceProviderProxy remoteServiceProvider;
   LocalServiceProvider _localServiceProvider;
   final _nameToServiceFactory = new Map<String, ServiceFactory>();
   FallbackServiceFactory _fallbackServiceFactory;
 
-  ApplicationConnection(ServiceProviderStub stub, ServiceProviderProxy proxy)
+  ApplicationConnection(
+      ServiceProviderBinding binding, ServiceProviderProxy proxy)
       : remoteServiceProvider = proxy {
-    if (stub != null) _localServiceProvider =
-        new LocalServiceProvider(this, stub);
+    if (binding != null)
+      _localServiceProvider = new LocalServiceProvider(this, binding);
   }
 
   FallbackServiceFactory get fallbackServiceFactory => _fallbackServiceFactory;
                          set fallbackServiceFactory(FallbackServiceFactory f) {
     assert(_localServiceProvider != null);
     _fallbackServiceFactory = f;
   }
 
   bindings.ProxyBase requestService(bindings.ProxyBase proxy) {
     assert(!proxy.impl.isBound &&
         (remoteServiceProvider != null) &&
         remoteServiceProvider.impl.isBound);
     var pipe = new core.MojoMessagePipe();
     proxy.impl.bind(pipe.endpoints[0]);
     remoteServiceProvider.ptr.connectToService(
         proxy.name, pipe.endpoints[1]);
     return proxy;
   }
 
   void provideService(String interfaceName, ServiceFactory factory) {
     assert(_localServiceProvider != null);
     _nameToServiceFactory[interfaceName] = factory;
   }
 
-  void listen() {
+  void listen({Function onClosed}) {
     assert(_localServiceProvider != null);
-    _localServiceProvider.listen();
+    _localServiceProvider.listen(onClosed: onClosed);
   }
 
   void close({bool nodefer: false}) {
     if (remoteServiceProvider != null) {
       remoteServiceProvider.close();
       remoteServiceProvider = null;
     }
     if (_localServiceProvider != null) {
       _localServiceProvider.close(nodefer: nodefer);
       _localServiceProvider = null;
     }
 
   }
 }