[list.js] Consider vertical paddings of list view when scrolling

[list.js] Consider vertical paddings of list view when scrolling

Previously, the paddings were not considered in the check if the row was visible or not. This patch fixes this bug.

BUG=324819
TEST=manually tested

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238291

[yoshiki, 2013-12-02 16:22:11]

@arv, could you take a look? Thanks.

[arv (Not doing code reviews), 2013-12-02 16:30:26]

LGTM

https://codereview.chromium.org/96823002/diff/60001/ui/webui/resources/js/cr/...
File ui/webui/resources/js/cr/ui/list.js (right):

https://codereview.chromium.org/96823002/diff/60001/ui/webui/resources/js/cr/...
ui/webui/resources/js/cr/ui/list.js:727: self.scrollTop = top + itemHeight -
availableHeight;
This changes the behavior too.

In the old code we only scrolled if the item was outside the viewport. Now we
scroll to the bottom at all times.

...but it seems like this case is already covered.

[yoshiki, 2013-12-03 01:12:01]

https://codereview.chromium.org/96823002/diff/60001/ui/webui/resources/js/cr/...
File ui/webui/resources/js/cr/ui/list.js (right):

https://codereview.chromium.org/96823002/diff/60001/ui/webui/resources/js/cr/...
ui/webui/resources/js/cr/ui/list.js:727: self.scrollTop = top + itemHeight -
availableHeight;
On 2013/12/02 16:30:27, arv wrote:
> This changes the behavior too.
> 
> In the old code we only scrolled if the item was outside the viewport. Now we
> scroll to the bottom at all times.
> 
> ...but it seems like this case is already covered.

Yes, this check is already done in the callers.

[commit-bot: I haz the power, 2013-12-03 01:12:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/96823002/60001

[commit-bot: I haz the power, 2013-12-03 03:28:14]

Change committed as 238291