Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 968193006: Don't relaunch app for non-auth errors. (Closed)

Created:
5 years, 9 months ago by Jamie
Modified:
5 years, 9 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't relaunch app for non-auth errors. BUG=464020 Committed: https://crrev.com/e5afa2379bb90d162a2a14b27262b0e8fec73329 Cr-Commit-Position: refs/heads/master@{#319151}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/webapp/crd/js/remoting.js View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 9 (2 generated)
Jamie
ptal
5 years, 9 months ago (2015-03-04 19:51:40 UTC) #2
kelvinp
https://codereview.chromium.org/968193006/diff/1/remoting/webapp/crd/js/remoting.js File remoting/webapp/crd/js/remoting.js (left): https://codereview.chromium.org/968193006/diff/1/remoting/webapp/crd/js/remoting.js#oldcode185 remoting/webapp/crd/js/remoting.js:185: if (base.isAppsV2()) { I think another problem is that ...
5 years, 9 months ago (2015-03-04 21:06:56 UTC) #3
kelvinp
lgtm
5 years, 9 months ago (2015-03-04 21:15:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968193006/1
5 years, 9 months ago (2015-03-04 21:21:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 22:49:35 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e5afa2379bb90d162a2a14b27262b0e8fec73329 Cr-Commit-Position: refs/heads/master@{#319151}
5 years, 9 months ago (2015-03-04 22:51:00 UTC) #8
Jamie
5 years, 9 months ago (2015-03-04 23:11:20 UTC) #9
Message was sent while issue was closed. 
FYI

https://codereview.chromium.org/968193006/diff/1/remoting/webapp/crd/js/remot...
File remoting/webapp/crd/js/remoting.js (left):

https://codereview.chromium.org/968193006/diff/1/remoting/webapp/crd/js/remot...
remoting/webapp/crd/js/remoting.js:185: if (base.isAppsV2()) {
On 2015/03/04 21:06:56, kelvinp wrote:
> I think another problem is that at error.js
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/webapp/cr...
> 
> We handle all unknown HTTP error as AUTHENTICATION_FAILED.
> Would that needs to be addressed as well?

Kelvin and I discussed in person, and felt that since unexpected HTTP response
codes are (hopefully) rare, we can ignore that problem for the time being.

Powered by Google App Engine
This is Rietveld 408576698