Issue 968193002: Cleanup: Fix tools/gn header include guards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 968193002: Cleanup: Fix tools/gn header include guards. (Closed)

Created:
5 years, 9 months ago by tfarina

Modified:
5 years, 9 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina, brettw

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Cleanup: Fix tools/gn header include guards. The header include guards should match the file path from root. These entries were found using a modified version of Eric's fix-include-guards.py script found attached in https://code.google.com/p/chromium/issues/detail?id=435361#c7. BUG=435361 TEST=gn_unittests R=scottmg@chromium.org Committed: https://crrev.com/7a2e9b912569846fce9e92c91a35167849ffcf71 Cr-Commit-Position: refs/heads/master@{#318719}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	tools/gn/c_include_iterator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/commands.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/ninja_build_writer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/substitution_list.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968193002/1

5 years, 9 months ago (2015-03-02 17:42:44 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-02 17:46:28 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7a2e9b912569846fce9e92c91a35167849ffcf71
Cr-Commit-Position: refs/heads/master@{#318719}