Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: tests/language/vm/regress_22621_vm_test.dart

Issue 968183003: Emit stackmaps even in unoptimized code if slow path pushes untagged values. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/flow_graph_compiler.cc ('K') | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/vm/regress_22621_vm_test.dart
diff --git a/tests/compiler/dart2js_extra/22487_test.dart b/tests/language/vm/regress_22621_vm_test.dart
similarity index 50%
copy from tests/compiler/dart2js_extra/22487_test.dart
copy to tests/language/vm/regress_22621_vm_test.dart
index 4bf5426b20e4dc4508044fb5aa0884afe5082e4a..f8e39a7ca2da80d48e81044f21747bad09485a67 100644
--- a/tests/compiler/dart2js_extra/22487_test.dart
+++ b/tests/language/vm/regress_22621_vm_test.dart
@@ -1,13 +1,10 @@
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-
-// Regression test for http://dartbug.com/22487
-
-import 'package:expect/expect.dart';
-
-divIsInt(a, b) => (a / b) is int;
+// Test that BoxAllocationSlowPath for Mint emits stackmap in unoptimized code.
+// VMOptions=--gc_at_instance_allocation=_Mint --inline_alloc=false
main() {
- Expect.isFalse((divIsInt)(10, 3));
+ var re = new RegExp(r"IsolateStubs (.*)");
+ return re.firstMatch("oooo");
koda 2015/03/03 17:57:48 Perhaps I should have added a comment here: "oooo"
Vyacheslav Egorov (Google) 2015/03/03 18:01:07 Acknowledged.
}
« runtime/vm/flow_graph_compiler.cc ('K') | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698