Emit stackmaps even in unoptimized code if slow path pushes untagged values.

runtime/vm/flow_graph_compiler.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_COMPILER_H_
 #define VM_FLOW_GRAPH_COMPILER_H_
 
 #include "vm/allocation.h"
 #include "vm/assembler.h"
 #include "vm/code_descriptors.h"
@@ skipping 619 matching lines @@
   void CompactBlocks();
 
   bool IsListClass(const Class& cls) const {
     return cls.raw() == list_class_.raw();
   }
 
   void EmitSourceLine(Instruction* instr);
 
   intptr_t GetOptimizationThreshold() const;
 
+  StackmapTableBuilder* stackmap_table_builder() {
+    if (stackmap_table_builder_ == NULL) {
+      stackmap_table_builder_ = new StackmapTableBuilder();

[koda, 2015/03/03 17:57:48]

Memory leak?

We should also assert in the destructor that the stack maps were actually
finalized (if non-NULL).

[Vyacheslav Egorov (Google), 2015/03/03 18:01:07]

it's a ZoneAllocated object as most of the things in the compiler, so it can't
leak anywhere (thus neither does it have its destructor invoked)

+    }
+    return stackmap_table_builder_;
+  }
+
   Isolate* isolate_;
   Assembler* assembler_;
   const ParsedFunction& parsed_function_;
   const FlowGraph& flow_graph_;
   const GrowableArray<BlockEntryInstr*>& block_order_;
 
   // Compiler specific per-block state.  Indexed by postorder block number
   // for convenience.  This is not the block's index in the block order,
   // which is reverse postorder.
   BlockEntryInstr* current_block_;
@@ skipping 39 matching lines @@
   const Array* inlined_code_intervals_;
   const GrowableArray<const Function*>& inline_id_to_function_;
   const GrowableArray<intptr_t>& caller_inline_id_;
 
   DISALLOW_COPY_AND_ASSIGN(FlowGraphCompiler);
 };
 
 }  // namespace dart
 
 #endif  // VM_FLOW_GRAPH_COMPILER_H_