Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 968113002: [turbofan] Skip write barriers when storing smi. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Skip write barriers when storing smi. On 64-bit targets, we can skip the write barrier for Store nodes if the input is ChangeInt32ToTagged, because the value being stored is definitely represented as a smi then. R=jarin@chromium.org Committed: https://crrev.com/155278d6f26f97631c3cf42caaf73927d007bf47 Cr-Commit-Position: refs/heads/master@{#26934}

Patch Set 1 #

Patch Set 2 : SimplifiedLowering approach. #

Patch Set 3 : Add test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M src/compiler/simplified-lowering.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 3 chunks +9 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-02 06:35:00 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-02 06:35:16 UTC) #2
Jarin
lgtm
5 years, 9 months ago (2015-03-02 08:26:45 UTC) #3
Benedikt Meurer
Committed patchset #3 (id:40001) manually as 155278d6f26f97631c3cf42caaf73927d007bf47 (presubmit successful).
5 years, 9 months ago (2015-03-02 09:09:16 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 09:09:17 UTC) #5
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/155278d6f26f97631c3cf42caaf73927d007bf47
Cr-Commit-Position: refs/heads/master@{#26934}

Powered by Google App Engine
This is Rietveld 408576698