Source/bindings/scripts/v8_interface.py - Issue 968033002: IDL: Support deleter operation with any return type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 968033002: IDL: Support deleter operation with any return type (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index a18866e335516c2cd61474d1f56c89a71466c3d9..61109d55e73fde38efae9f950e0ee37707119ad7 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -1299,10 +1299,6 @@ def property_deleter(deleter):

return None

idl_type = deleter.idl_type

- if str(idl_type) != 'boolean':

- raise Exception(

- 'Only deleters with boolean type are allowed, but type is "%s"' %

- idl_type)

extended_attributes = deleter.extended_attributes

return {

'is_custom': 'Custom' in extended_attributes,

« no previous file with comments | « no previous file | no next file » | no next file with comments »