Source/bindings/v8/ExceptionState.cpp - Issue 96793002: Switch custom XMLHttpRequest bindings over to new-style ExceptionState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ExceptionState.cpp

Issue 96793002: Switch custom XMLHttpRequest bindings over to new-style ExceptionState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/xmlhttprequest/reentrant-cancel-expected.txt ('k') | Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp » ('j') | Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/ExceptionState.cpp

diff --git a/Source/bindings/v8/ExceptionState.cpp b/Source/bindings/v8/ExceptionState.cpp

index 10223be501609f4e46f82c060cf93c30a25b5395..9ff489d4332cd691df71aa4217a3887b42c2aba0 100644

--- a/Source/bindings/v8/ExceptionState.cpp

+++ b/Source/bindings/v8/ExceptionState.cpp

@@ -80,7 +80,8 @@ void ExceptionState::throwTypeError(const String& message)

{

ASSERT(m_isolate);

m_code = TypeError;

- setException(V8ThrowException::createTypeError(message, m_isolate));

+ String processedMessage = addExceptionContext(message);

Mike West 2013/11/29 11:28:12 Nit: I'd drop the temporary string here. You can j

sof 2013/11/29 11:36:05 Done.

+ setException(V8ThrowException::createTypeError(processedMessage, m_isolate));

}

void TrackExceptionState::throwDOMException(const ExceptionCode& ec, const String& message)