Issue 96793002: Switch custom XMLHttpRequest bindings over to new-style ExceptionState.

Issue 96793002: Switch custom XMLHttpRequest bindings over to new-style ExceptionState. (Closed)

Created:
7 years ago by sof

Modified:
7 years ago

Reviewers:
Mike West, jochen (gone - plz use gerrit)

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Switch custom XMLHttpRequest bindings over to new-style ExceptionState. Configure incoming ExceptionState with the calling context instead of detailing at the point where the exception is raised. To support throwing context-sensitive TypeErrors, extend ExceptionState::throwTypeError() to also embellish its incoming messages. R=mkwst BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162909

Patch Set 1 #

Total comments: 3

Patch Set 2 : Inline local binding in throwTypeError() #

Created: 7 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+260 lines, -265 lines)			Patch
LayoutTests/fast/js/dfg-custom-getter-throw-expected.txt	View		1 chunk	+100 lines, -100 lines	0 comments	Download
LayoutTests/fast/js/dfg-custom-getter-throw-inlined-expected.txt	View		1 chunk	+100 lines, -100 lines	0 comments	Download
LayoutTests/fast/js/script-tests/dfg-custom-getter-throw.js	View		1 chunk	+1 line, -1 line	0 comments	Download
LayoutTests/fast/js/script-tests/dfg-custom-getter-throw-inlined.js	View		1 chunk	+1 line, -1 line	0 comments	Download
LayoutTests/fast/xmlhttprequest/xmlhttprequest-open-exceptions.html	View		1 chunk	+1 line, -1 line	0 comments	Download
LayoutTests/fast/xmlhttprequest/xmlhttprequest-open-exceptions-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
LayoutTests/fast/xmlhttprequest/xmlhttprequest-responseXML-xml-text-responsetype-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt	View		1 chunk	+3 lines, -3 lines	0 comments	Download
LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request-expected.txt	View		1 chunk	+2 lines, -2 lines	0 comments	Download
LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-document-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received-expected.txt	View		1 chunk	+2 lines, -2 lines	0 comments	Download
LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request-expected.txt	View		1 chunk	+2 lines, -2 lines	0 comments	Download
LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-text-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
LayoutTests/http/tests/xmlhttprequest/exceptions-expected.txt	View		1 chunk	+4 lines, -4 lines	0 comments	Download
LayoutTests/http/tests/xmlhttprequest/reentrant-cancel-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
Source/bindings/v8/ExceptionState.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp	View		4 chunks	+23 lines, -28 lines	0 comments	Download
Source/core/xml/XMLHttpRequest.cpp	View		12 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sof

At your leisure, please take a look. (responseXML will have to wait until the generated ...

7 years ago (2013-11-29 11:07:06 UTC) #1

Mike West

LGTM, thanks again. https://codereview.chromium.org/96793002/diff/1/Source/bindings/v8/ExceptionState.cpp File Source/bindings/v8/ExceptionState.cpp (right): https://codereview.chromium.org/96793002/diff/1/Source/bindings/v8/ExceptionState.cpp#newcode83 Source/bindings/v8/ExceptionState.cpp:83: String processedMessage = addExceptionContext(message); Nit: I'd ...

7 years ago (2013-11-29 11:28:11 UTC) #2

sof

Thanks much for the quick feedback. https://codereview.chromium.org/96793002/diff/1/Source/bindings/v8/ExceptionState.cpp File Source/bindings/v8/ExceptionState.cpp (right): https://codereview.chromium.org/96793002/diff/1/Source/bindings/v8/ExceptionState.cpp#newcode83 Source/bindings/v8/ExceptionState.cpp:83: String processedMessage = ...

7 years ago (2013-11-29 11:36:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/96793002/20001

7 years ago (2013-11-29 11:36:27 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=19052

7 years ago (2013-11-29 13:57:36 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/96793002/20001

7 years ago (2013-11-29 14:08:11 UTC) #6

Message was sent while issue was closed.

Change committed as 162909

Expand Messages | Collapse Messages