Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: Source/core/loader/FrameFetchContext.h

Issue 967893002: Have FrameFetchContext check for frame detached status more often. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 public: 51 public:
52 static PassRefPtrWillBeRawPtr<ResourceFetcher> createContextAndFetcher(Docum entLoader* loader) 52 static PassRefPtrWillBeRawPtr<ResourceFetcher> createContextAndFetcher(Docum entLoader* loader)
53 { 53 {
54 return ResourceFetcher::create(adoptPtrWillBeNoop(new FrameFetchContext( loader))); 54 return ResourceFetcher::create(adoptPtrWillBeNoop(new FrameFetchContext( loader)));
55 } 55 }
56 56
57 ~FrameFetchContext(); 57 ~FrameFetchContext();
58 58
59 LocalFrame* frame() const override; // Can be null 59 LocalFrame* frame() const override; // Can be null
60 Document* document() const override { return m_document; } // Can be null 60 Document* document() const override { return m_document; } // Can be null
61 void setDocument(RawPtr<Document> document) { m_document = document; } 61 void setDocument(Document* document) { m_document = document; }
62 DocumentLoader* documentLoader() const override { return m_documentLoader; } 62 DocumentLoader* documentLoader() const override { return m_documentLoader; }
63 void clearDocumentLoader() { m_documentLoader = nullptr; } 63 void clearDocumentLoader() { m_documentLoader = nullptr; }
64 64
65 virtual void reportLocalLoadFailed(const KURL&) override; 65 virtual void reportLocalLoadFailed(const KURL&) override;
66 virtual void addAdditionalRequestHeaders(Document*, ResourceRequest&, FetchR esourceType) override; 66 virtual void addAdditionalRequestHeaders(Document*, ResourceRequest&, FetchR esourceType) override;
67 virtual void setFirstPartyForCookies(ResourceRequest&) override; 67 virtual void setFirstPartyForCookies(ResourceRequest&) override;
68 virtual CachePolicy cachePolicy(Document*) const override; 68 virtual CachePolicy cachePolicy(Document*) const override;
69 virtual void dispatchDidChangeResourcePriority(unsigned long identifier, Res ourceLoadPriority, int intraPriorityValue); 69 virtual void dispatchDidChangeResourcePriority(unsigned long identifier, Res ourceLoadPriority, int intraPriorityValue);
70 virtual void dispatchWillSendRequest(DocumentLoader*, unsigned long identifi er, ResourceRequest&, const ResourceResponse& redirectResponse, const FetchIniti atorInfo& = FetchInitiatorInfo()) override; 70 virtual void dispatchWillSendRequest(DocumentLoader*, unsigned long identifi er, ResourceRequest&, const ResourceResponse& redirectResponse, const FetchIniti atorInfo& = FetchInitiatorInfo()) override;
71 virtual void dispatchDidLoadResourceFromMemoryCache(const ResourceRequest&, const ResourceResponse&) override; 71 virtual void dispatchDidLoadResourceFromMemoryCache(const ResourceRequest&, const ResourceResponse&) override;
(...skipping 13 matching lines...) Expand all
85 // FIXME: Oilpan: Ideally this should just be a traced Member but that will 85 // FIXME: Oilpan: Ideally this should just be a traced Member but that will
86 // currently leak because LayoutStyle and its data are not on the heap. 86 // currently leak because LayoutStyle and its data are not on the heap.
87 // See crbug.com/383860 for details. 87 // See crbug.com/383860 for details.
88 RawPtrWillBeWeakMember<Document> m_document; 88 RawPtrWillBeWeakMember<Document> m_document;
89 DocumentLoader* m_documentLoader; 89 DocumentLoader* m_documentLoader;
90 }; 90 };
91 91
92 } 92 }
93 93
94 #endif 94 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698