Replace string uses with code units in Json parser.

Replace string uses with code units in Json parser.

Also adds a test.

R=ajohnsen@google.com

Fetch live buildbot changes.

BUG=

Committed: https://github.com/dart-lang/fletch/commit/0d6c07ff7973114a43b19fe7482c8401564b804c

[zerny-google, 2015-03-04 14:48:16]

PTAL

[Anders Johnsen, 2015-03-05 07:35:31]

LGTM, with comments!

https://codereview.chromium.org/967883004/diff/1/samples/buildbot/json.dart
File samples/buildbot/json.dart (right):

https://codereview.chromium.org/967883004/diff/1/samples/buildbot/json.dart#n...
samples/buildbot/json.dart:123: _optional(_CHAR_COMMA);
Would this allow

 [1 2 3 4]

?

(ditto above)

https://codereview.chromium.org/967883004/diff/1/samples/buildbot/tests/json_...
File samples/buildbot/tests/json_test.dart (right):

https://codereview.chromium.org/967883004/diff/1/samples/buildbot/tests/json_...
samples/buildbot/tests/json_test.dart:37: .parse());
Expect.throws(() => new JsonParser('[1 2 3 4 5]').parse());

[zerny-google, 2015-03-05 08:12:32]

Thanks for the review. Improvement of map/list parsing is in the latest patch
set.

https://codereview.chromium.org/967883004/diff/1/samples/buildbot/json.dart
File samples/buildbot/json.dart (right):

https://codereview.chromium.org/967883004/diff/1/samples/buildbot/json.dart#n...
samples/buildbot/json.dart:123: _optional(_CHAR_COMMA);
On 2015/03/05 07:35:31, Anders Johnsen wrote:
> Would this allow
> 
>  [1 2 3 4]
> 
> ?
> 
> (ditto above)

Yes. Fortunately it does parse well-formed json :-) but I'll refactor to force
an error on ill-formed lists/maps.

https://codereview.chromium.org/967883004/diff/1/samples/buildbot/tests/json_...
File samples/buildbot/tests/json_test.dart (right):

https://codereview.chromium.org/967883004/diff/1/samples/buildbot/tests/json_...
samples/buildbot/tests/json_test.dart:37: .parse());
On 2015/03/05 07:35:31, Anders Johnsen wrote:
> Expect.throws(() => new JsonParser('[1 2 3 4 5]').parse());

Done.

[Anders Johnsen, 2015-03-05 08:26:10]

LGTM!

[zerny-google, 2015-03-05 09:17:38]

Committed patchset #2 (id:20001) manually as
0d6c07ff7973114a43b19fe7482c8401564b804c (presubmit successful).