src/heap-inl.h - Issue 96783002: Allocation site pretenuring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-inl.h

Issue 96783002: Allocation site pretenuring. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap-inl.h

diff --git a/src/heap-inl.h b/src/heap-inl.h

index 3dce348727477c260c894f3710956e4fe0e2ce8f..22048fcbec6d5095552aa304559704ad6a7c3d00 100644

--- a/src/heap-inl.h

+++ b/src/heap-inl.h

@@ -484,15 +484,16 @@ void Heap::ScavengePointer(HeapObject** p) {

void Heap::UpdateAllocationSiteFeedback(HeapObject* object) {

+ Heap* heap = object->GetIsolate()->heap();

Michael Starzinger 2014/01/10 09:10:23 nit: Just "object->GetHeap()" here.

Hannes Payer (out of office) 2014/01/10 12:03:30 Done.

if (FLAG_allocation_site_pretenuring &&

+ heap->new_space_high_promotion_mode_active_ &&

AllocationSite::CanTrack(object->map()->instance_type())) {

AllocationMemento* memento = AllocationMemento::FindForHeapObject(

- object, true);

+ object, heap, true);

if (memento != NULL) {

ASSERT(memento->IsValid());

bool add_to_scratchpad =

memento->GetAllocationSite()->IncrementMementoFoundCount();

- Heap* heap = object->GetIsolate()->heap();

if (add_to_scratchpad && heap->allocation_sites_scratchpad_length <

kAllocationSiteScratchpadSize) {

heap->allocation_sites_scratchpad[

« no previous file with comments | « src/heap.cc ('k') | src/hydrogen.cc » ('j') | test/cctest/test-heap.cc » ('J')