Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 967753003: Add the NonElementParentNode interface (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add the NonElementParentNode interface As a side effect, DocumentFragment.getElementById now also has per-world bindings. This makes the generated code bigger, and probably won't help. Use [LegacyTreatAsPartialInterface] like the other *Node interfaces. BUG=462916 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191066

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M Source/core/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/Document.idl View 1 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/dom/DocumentFragment.idl View 1 chunk +3 lines, -2 lines 0 comments Download
A Source/core/dom/NonElementParentNode.h View 1 chunk +28 lines, -0 lines 0 comments Download
A Source/core/dom/NonElementParentNode.idl View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-01 03:04:55 UTC) #2
haraken
LGTM https://codereview.chromium.org/967753003/diff/1/Source/core/dom/NonElementParentNode.h File Source/core/dom/NonElementParentNode.h (right): https://codereview.chromium.org/967753003/diff/1/Source/core/dom/NonElementParentNode.h#newcode13 Source/core/dom/NonElementParentNode.h:13: class NonElementParentNode { Add final.
5 years, 9 months ago (2015-03-01 08:53:07 UTC) #3
philipj_slow
https://codereview.chromium.org/967753003/diff/1/Source/core/dom/NonElementParentNode.h File Source/core/dom/NonElementParentNode.h (right): https://codereview.chromium.org/967753003/diff/1/Source/core/dom/NonElementParentNode.h#newcode13 Source/core/dom/NonElementParentNode.h:13: class NonElementParentNode { On 2015/03/01 08:53:07, haraken wrote: > ...
5 years, 9 months ago (2015-03-01 15:32:14 UTC) #4
haraken
On 2015/03/01 15:32:14, philipj_UTC7 wrote: > https://codereview.chromium.org/967753003/diff/1/Source/core/dom/NonElementParentNode.h > File Source/core/dom/NonElementParentNode.h (right): > > https://codereview.chromium.org/967753003/diff/1/Source/core/dom/NonElementParentNode.h#newcode13 > ...
5 years, 9 months ago (2015-03-01 16:30:27 UTC) #5
philipj_slow
Thanks, landing this as-is then :)
5 years, 9 months ago (2015-03-01 16:34:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967753003/1
5 years, 9 months ago (2015-03-01 16:35:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/27967)
5 years, 9 months ago (2015-03-01 16:50:21 UTC) #10
philipj_slow
rebase
5 years, 9 months ago (2015-03-01 17:03:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967753003/20001
5 years, 9 months ago (2015-03-01 17:04:03 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-01 18:28:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191066

Powered by Google App Engine
This is Rietveld 408576698