Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: remoting/webapp/crd/js/client_plugin_impl.js

Issue 967733006: Disable VideoDecoder renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/client_plugin_impl.js
diff --git a/remoting/webapp/crd/js/client_plugin_impl.js b/remoting/webapp/crd/js/client_plugin_impl.js
index 45b95ba5206f49a8b14b18493d5e363166ef26ab..c1e51ba50ff5bd790b61f4024600de5cead6ca13 100644
--- a/remoting/webapp/crd/js/client_plugin_impl.js
+++ b/remoting/webapp/crd/js/client_plugin_impl.js
@@ -581,12 +581,10 @@ remoting.ClientPluginImpl.prototype.connect =
} else if (remoting.platformIsChromeOS()) {
keyFilter = 'cros';
}
- // Use PPB_VideoDecoder API only in Chrome 42 and above. It is broken in
- // previous versions of Chrome, see http://crbug.com/447403 .
- // Currently PPAPI doesn't provide a way for plugins to check the Chrome
- // version, so this check needs to be in the webapp.
- var enableVideoDecodeRenderer =
- parseInt((remoting.getChromeVersion() || '0').split('.')[0], 10) >= 42;
+
+ // PPB_VideoDecoder-based renderer is disabled because it's broken in some
+ // scenarios, see crbug.com/459103 and crbug.com/463577 .
+ var enableVideoDecodeRenderer = false;
Wez 2015/03/03 19:50:42 Make this a >= 43 check so that we use the VideoDe
Sergey Ulanov 2015/03/03 19:57:12 Done.
this.plugin_.postMessage(JSON.stringify(
{ method: 'delegateLargeCursors', data: {} }));
var methods = 'third_party,spake2_pair,spake2_hmac,spake2_plain';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698