Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 967733006: Disable VideoDecoder renderer. (Closed)

Created:
5 years, 9 months ago by Sergey Ulanov
Modified:
5 years, 9 months ago
Reviewers:
Jamie, Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable VideoDecoder renderer in M42 chrome. There are some issues with the VideoDecoder renderer in M42 chrome, particularly on ARM. Don't use it there. BUG=459103, 463577 Committed: https://crrev.com/5b546a437eabff7aaa420ad3f17bbd6397dc3666 Cr-Commit-Position: refs/heads/master@{#318966}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M remoting/webapp/crd/js/client_plugin_impl.js View 1 2 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sergey Ulanov
5 years, 9 months ago (2015-03-03 19:45:00 UTC) #4
Wez
https://codereview.chromium.org/967733006/diff/40001/remoting/webapp/crd/js/client_plugin_impl.js File remoting/webapp/crd/js/client_plugin_impl.js (right): https://codereview.chromium.org/967733006/diff/40001/remoting/webapp/crd/js/client_plugin_impl.js#newcode587 remoting/webapp/crd/js/client_plugin_impl.js:587: var enableVideoDecodeRenderer = false; Make this a >= 43 ...
5 years, 9 months ago (2015-03-03 19:50:42 UTC) #6
Sergey Ulanov
https://codereview.chromium.org/967733006/diff/40001/remoting/webapp/crd/js/client_plugin_impl.js File remoting/webapp/crd/js/client_plugin_impl.js (right): https://codereview.chromium.org/967733006/diff/40001/remoting/webapp/crd/js/client_plugin_impl.js#newcode587 remoting/webapp/crd/js/client_plugin_impl.js:587: var enableVideoDecodeRenderer = false; On 2015/03/03 19:50:42, Wez wrote: ...
5 years, 9 months ago (2015-03-03 19:57:12 UTC) #7
Jamie
lgtm
5 years, 9 months ago (2015-03-03 20:06:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967733006/80001
5 years, 9 months ago (2015-03-03 22:09:18 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 9 months ago (2015-03-04 00:03:53 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:05:26 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5b546a437eabff7aaa420ad3f17bbd6397dc3666
Cr-Commit-Position: refs/heads/master@{#318966}

Powered by Google App Engine
This is Rietveld 408576698