Issue 96773002: Handle captured objects in OptimizedFrame::Summarize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 96773002: Handle captured objects in OptimizedFrame::Summarize. (Closed)

Created:
7 years ago by Michael Starzinger

Modified:
7 years ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Handle captured objects in OptimizedFrame::Summarize. R=yangguo@chromium.org BUG=v8:3029 TEST=mjsunit/regress/regress-3029 LOG=N Committed: http://code.google.com/p/v8/source/detail?r=18187

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -21 lines)			Patch
M	src/frames.cc	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/isolate.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
A +	test/mjsunit/regress/regress-3029.js	View	1 chunk	+9 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

As dicussed offline, the stack traces are still bogus in this case, but at least ...

7 years ago (2013-11-29 10:56:10 UTC) #1

Yang

On 2013/11/29 10:56:10, Michael Starzinger wrote: > As dicussed offline, the stack traces are still ...

7 years ago (2013-11-29 14:51:26 UTC) #2

Michael Starzinger

7 years ago (2013-12-02 12:11:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18187 (presubmit successful).