Cast: Fix crash in udp_transport

Cast: Fix crash in udp_transport

When connecting to a port on localhost which is not yet open, connect fails and udp_socket crashes when trying to send packets. This fixes that.

Committed: https://crrev.com/f90e67e8844bf3c40c1091bd843a3ee11c9bc1c3
Cr-Commit-Position: refs/heads/master@{#330442}

[hubbe, 2015-05-07 20:04:56]

hubbe@chromium.org changed reviewers:
+ miu@chromium.org

[miu, 2015-05-08 06:49:05]

lgtm % one consideration:

https://codereview.chromium.org/967723002/diff/10002/media/cast/net/udp_trans...
File media/cast/net/udp_transport.cc (right):

https://codereview.chromium.org/967723002/diff/10002/media/cast/net/udp_trans...
media/cast/net/udp_transport.cc:70: 
Should there be a guard here too?

  if (!udp_socket_) {
    status_callback.Run(TRANSPORT_SOCKET_ERROR);
    return;
  }

[hubbe, 2015-05-18 20:41:06]

https://codereview.chromium.org/967723002/diff/10002/media/cast/net/udp_trans...
File media/cast/net/udp_transport.cc (right):

https://codereview.chromium.org/967723002/diff/10002/media/cast/net/udp_trans...
media/cast/net/udp_transport.cc:70: 
On 2015/05/08 06:49:05, miu wrote:
> Should there be a guard here too?
> 
>   if (!udp_socket_) {
>     status_callback.Run(TRANSPORT_SOCKET_ERROR);
>     return;
>   }

Done.

Although, a DCHECK might be better as we don't really expect
StartReceiving to be called twice.

[hubbe, 2015-05-18 20:41:15]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2015-05-18 20:41:16]

The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org
Link to the patchset: https://codereview.chromium.org/967723002/#ps50001 (title:
"typ0")

[commit-bot: I haz the power, 2015-05-18 20:44:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/967723002/50001

[commit-bot: I haz the power, 2015-05-18 22:29:18]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2015-05-18 22:44:51]

Patchset 4 (id:??) landed as
https://crrev.com/f90e67e8844bf3c40c1091bd843a3ee11c9bc1c3
Cr-Commit-Position: refs/heads/master@{#330442}