pkg/analyzer/lib/src/generated/resolver.dart - Issue 967703002: Avoid unnecessary parsing/resolution when running command line analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 967703002: Avoid unnecessary parsing/resolution when running command line analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analyzer/lib/src/generated/parser.dart ('K') | « pkg/analyzer/lib/src/generated/parser.dart ('k') | pkg/analyzer/lib/src/task/dart.dart » ('j') | pkg/analyzer/test/generated/engine_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/src/generated/resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart

index 9a32064014e87c9666068cb7846c060ecc28ba5f..b239b70b25b86c77110cb1c4486af529b9b34f7c 100644

--- a/pkg/analyzer/lib/src/generated/resolver.dart

+++ b/pkg/analyzer/lib/src/generated/resolver.dart

@@ -2993,7 +2993,7 @@ class ElementBuilder extends RecursiveAstVisitor<Object> {

}

getter.variable = field;

getter.abstract =

- body is EmptyFunctionBody && node.externalKeyword == null;

+ body is EmptyFunctionBody && !body.semicolon.isSynthetic && node.externalKeyword == null;

scheglov 2015/02/28 02:47:31 Looks like a duplicate code. Fix https://coderevie

Paul Berry 2015/03/02 19:09:46 Thanks.

getter.getter = true;

getter.static = isStatic;

field.getter = getter;

@@ -3013,7 +3013,7 @@ class ElementBuilder extends RecursiveAstVisitor<Object> {

setter.generator = true;

}

setter.variable = field;

- setter.abstract = body is EmptyFunctionBody &&

+ setter.abstract = body is EmptyFunctionBody && !body.semicolon.isSynthetic &&

!_matches(node.externalKeyword, sc.Keyword.EXTERNAL);

setter.setter = true;

setter.static = isStatic;