Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 967693002: Clang fixes for chromeos (Closed)

Created:
5 years, 9 months ago by stevenjb
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jdduke+watch_chromium.org, kalyank, mcasas+watch_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, tdresser+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clang fixes for chromeos This fixes clang builds with the simple chrome workflow: cros chrome-sdk --board=link --clang Unfortunately there are not currently any builders with this configuration. BUG=462767 Committed: https://crrev.com/079711fb00b3a1c89d26aad7a46e47c259066403 Cr-Commit-Position: refs/heads/master@{#318977}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -43 lines) Patch
M content/common/gpu/media/generic_v4l2_device.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/h264_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/h264_decoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc View 5 chunks +5 lines, -3 lines 0 comments Download
M content/common/gpu/media/vp8_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vp8_decoder.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M media/audio/cras/audio_manager_cras.h View 1 chunk +17 lines, -17 lines 0 comments Download
M media/audio/cras/cras_input.h View 1 chunk +11 lines, -10 lines 0 comments Download
M media/audio/cras/cras_unified.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_feedback.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
stevenjb
5 years, 9 months ago (2015-02-27 23:00:40 UTC) #2
stevenjb
5 years, 9 months ago (2015-02-27 23:12:57 UTC) #3
Pawel Osciak
content/common/gpu/media lgtm
5 years, 9 months ago (2015-02-27 23:24:20 UTC) #4
spang
https://codereview.chromium.org/967693002/diff/1/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc File ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc (right): https://codereview.chromium.org/967693002/diff/1/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc#newcode683 ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:683: bool Match(const DevicePtr device) override = 0; Just remove ...
5 years, 9 months ago (2015-02-27 23:28:47 UTC) #5
stevenjb
https://codereview.chromium.org/967693002/diff/1/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc File ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc (right): https://codereview.chromium.org/967693002/diff/1/ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc#newcode683 ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc:683: bool Match(const DevicePtr device) override = 0; On 2015/02/27 ...
5 years, 9 months ago (2015-03-03 22:02:57 UTC) #6
spang
lgtm
5 years, 9 months ago (2015-03-03 22:18:46 UTC) #7
stevenjb
tommi@ ping (or +dalecurtis@chromium.org)
5 years, 9 months ago (2015-03-03 22:57:09 UTC) #9
tommi (sloooow) - chröme
lgtm
5 years, 9 months ago (2015-03-03 23:50:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967693002/20001
5 years, 9 months ago (2015-03-04 00:03:59 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 00:30:14 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:31:09 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/079711fb00b3a1c89d26aad7a46e47c259066403
Cr-Commit-Position: refs/heads/master@{#318977}

Powered by Google App Engine
This is Rietveld 408576698