Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 967683003: Re-land "Clean up the top level BUILD.gn file." (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, eroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land "Clean up the top level BUILD.gn file." This re-lands #318523 with a fix for the mac build. TBR=brettw@chromium.org BUG=461019 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/d62d851ee66c30eb639d9309b7e17631bbbfd354 Cr-Commit-Position: refs/heads/master@{#318638}

Patch Set 1 : original patch #

Patch Set 2 : fix to the mac build #

Patch Set 3 : merge gn cleanup to #318608 #

Patch Set 4 : merge to #318628 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -54 lines) Patch
M BUILD.gn View 1 2 4 chunks +18 lines, -54 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967683003/20001
5 years, 9 months ago (2015-02-27 22:14:44 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_dbg on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_dbg/builds/170)
5 years, 9 months ago (2015-02-27 22:39:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967683003/40001
5 years, 9 months ago (2015-02-28 17:18:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/885)
5 years, 9 months ago (2015-02-28 17:23:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967683003/60001
5 years, 9 months ago (2015-03-01 20:53:31 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/996)
5 years, 9 months ago (2015-03-01 20:57:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967683003/60001
5 years, 9 months ago (2015-03-02 02:17:50 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-02 03:06:10 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 03:07:31 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d62d851ee66c30eb639d9309b7e17631bbbfd354
Cr-Commit-Position: refs/heads/master@{#318638}

Powered by Google App Engine
This is Rietveld 408576698