Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 967673002: [Sync] Make sure to register for autofill wallet invalidation on android (Closed)

Created:
5 years, 9 months ago by Nicolas Zea
Modified:
5 years, 9 months ago
Reviewers:
nyquist, brettw
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Make sure to register for autofill wallet invalidation on android Wallet was not receiving invalidation previously because the Android side did not know to register the type. This fixes that. BUG=none Committed: https://crrev.com/e3ac664ff10cf5b8ccb15e1f35228c81e937217f Cr-Commit-Position: refs/heads/master@{#318566}

Patch Set 1 #

Patch Set 2 : Make model type name match cc #

Patch Set 3 : invalidation type must match enum name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java View 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Nicolas Zea
+Tommy for review +Brett FYI
5 years, 9 months ago (2015-02-27 22:08:36 UTC) #2
nyquist
I think we should start using the auto-generate tool for these things instead, and just ...
5 years, 9 months ago (2015-02-27 22:28:52 UTC) #3
nyquist
I think we should start using the auto-generate tool for these things instead, and just ...
5 years, 9 months ago (2015-02-27 22:28:52 UTC) #4
brettw
Thanks for tracking this down.
5 years, 9 months ago (2015-02-27 22:33:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967673002/40001
5 years, 9 months ago (2015-02-28 00:48:43 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-02-28 01:40:36 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 01:41:19 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e3ac664ff10cf5b8ccb15e1f35228c81e937217f
Cr-Commit-Position: refs/heads/master@{#318566}

Powered by Google App Engine
This is Rietveld 408576698