Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 967623002: Remove display-options-display-view-mirroring. (Closed)

Created:
5 years, 9 months ago by Jun Mukai
Modified:
5 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove display-options-display-view-mirroring. In the CSS, this name is used for an ID, but in the JS side this name is used for a class name, it seems this name is just unused. It would be okay to use this as a class name, but this specifies margin only, and we don't see any claims about margin for mirroring view. Actually, mirroring displays are centered and sized well, so nobody notices the margin for the container. Let's just remove unused code. BUG=None R=dbeam@chromium.org Committed: https://crrev.com/8cc7fae05c3dc2c85bfce2348a12ad913e677ba2 Cr-Commit-Position: refs/heads/master@{#318534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/resources/options/chromeos/display_options.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/chromeos/display_options.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jun Mukai
5 years, 9 months ago (2015-02-27 20:19:37 UTC) #1
Dan Beam
lgtm++
5 years, 9 months ago (2015-02-27 21:29:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967623002/1
5 years, 9 months ago (2015-02-27 21:32:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 22:39:15 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 22:40:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cc7fae05c3dc2c85bfce2348a12ad913e677ba2
Cr-Commit-Position: refs/heads/master@{#318534}

Powered by Google App Engine
This is Rietveld 408576698