Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 967613003: Add components resources repack to GN build. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add components resources repack to GN build. This makes the components_unittests pass. Committed: https://crrev.com/77b5872e9a7181afcc3b59881af5218a0d42ea7b Cr-Commit-Position: refs/heads/master@{#318544}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 3 chunks +22 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 9 months ago (2015-02-27 22:02:34 UTC) #2
Dirk Pranke
lgtm
5 years, 9 months ago (2015-02-27 22:03:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967613003/1
5 years, 9 months ago (2015-02-27 22:19:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967613003/20001
5 years, 9 months ago (2015-02-27 22:33:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-27 23:35:14 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 23:35:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77b5872e9a7181afcc3b59881af5218a0d42ea7b
Cr-Commit-Position: refs/heads/master@{#318544}

Powered by Google App Engine
This is Rietveld 408576698