Rename sample_app -> spinning_cube.

Rename sample_app -> spinning_cube.

'Sample app' is pretty undescriptive, all apps in examples/ are 'sample'.

This also sets a temporary mapping of (sample_app -> spinning_cube) in
context.cc, so that the old name works for some time.

R=qsr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/69171515f8e53bc4db4b851ec9a93eda7e9f6323

[ppi, 2015-02-27 16:10:28]

Patchset #1 (id:1) has been deleted

[ppi, 2015-02-27 16:10:34]

Patchset #1 (id:20001) has been deleted

[ppi, 2015-02-27 16:11:53]

ppi@chromium.org changed reviewers:
+ jamesr@chromium.org, qsr@chromium.org

[ppi, 2015-02-27 16:12:06]

Hi Ben, James,

wdyt?

[qsr, 2015-02-27 16:16:44]

https://codereview.chromium.org/967563002/diff/40001/examples/spinning_cube/g...
File examples/spinning_cube/gles2_client_impl.h (right):

https://codereview.chromium.org/967563002/diff/40001/examples/spinning_cube/g...
examples/spinning_cube/gles2_client_impl.h:5: #ifndef
EXAMPLES_SAMPLE_APP_GLES2_CLIENT_IMPL_H_
This seems wrong.

https://codereview.chromium.org/967563002/diff/40001/shell/context.cc
File shell/context.cc (right):

https://codereview.chromium.org/967563002/diff/40001/shell/context.cc#newcode129
shell/context.cc:129: resolver->AddURLMapping(GURL("mojo:sample_app"),
GURL("mojo:spinning_cube"));
Not sure this is worth it. A mail on mojo-dev should be enough

On the other end, did you check that we didn't have documentation that
references this?

[ppi, 2015-02-27 16:27:49]

Thanks, Ben, ptal.

https://codereview.chromium.org/967563002/diff/40001/examples/spinning_cube/g...
File examples/spinning_cube/gles2_client_impl.h (right):

https://codereview.chromium.org/967563002/diff/40001/examples/spinning_cube/g...
examples/spinning_cube/gles2_client_impl.h:5: #ifndef
EXAMPLES_SAMPLE_APP_GLES2_CLIENT_IMPL_H_
On 2015/02/27 16:16:43, qsr wrote:
> This seems wrong.

Done.

https://codereview.chromium.org/967563002/diff/40001/shell/context.cc
File shell/context.cc (right):

https://codereview.chromium.org/967563002/diff/40001/shell/context.cc#newcode129
shell/context.cc:129: resolver->AddURLMapping(GURL("mojo:sample_app"),
GURL("mojo:spinning_cube"));
On 2015/02/27 16:16:43, qsr wrote:
> Not sure this is worth it. A mail on mojo-dev should be enough
> 
> On the other end, did you check that we didn't have documentation that
> references this?

I intended to set the mapping, send the email, and remove the mapping a week
later. Might save some people some time. I'm happy to skip the mapping part of
you or James feel strongly that it's not needed.

As for the documentation, I update the READMEs in this CL. Drive search for
"sample_app" didn't give me any hits.

[qsr, 2015-02-27 16:43:13]

I think I prefer without the mapping, but I'm not strongly opposed, so LGTM

[ppi, 2015-03-02 10:40:17]

ppi@chromium.org changed reviewers:
+ blundell@chromium.org

[ppi, 2015-03-02 10:41:06]

+Colin

Colin, do we need to update any CDN upload scripts?

[blundell, 2015-03-02 10:43:59]

On 2015/03/02 10:41:06, ppi wrote:
> +Colin
> 
> Colin, do we need to update any CDN upload scripts?

Nope.

[ppi, 2015-03-02 10:46:00]

Committed patchset #3 (id:80001) manually as
69171515f8e53bc4db4b851ec9a93eda7e9f6323 (presubmit successful).