Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 967553003: Add rewind capability to SkChunkAlloc (Closed)

Created:
5 years, 9 months ago by robertphillips
Modified:
5 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add rewind capability to SkChunkAlloc Split off from https://codereview.chromium.org/940533003/ (Decrease GrInOrderDrawBuffer::Cmd's reliance on GrInOrderDrawBuffer) Committed: https://skia.googlesource.com/skia/+/a9061de9ff8d5b9545e5d1ef7a6e4054e1907c95

Patch Set 1 #

Patch Set 2 : Fix variable sizes/signs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -34 lines) Patch
M include/core/SkChunkAlloc.h View 3 chunks +12 lines, -2 lines 0 comments Download
M src/core/SkChunkAlloc.cpp View 1 6 chunks +107 lines, -14 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/MemsetTest.cpp View 1 chunk +58 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
robertphillips
5 years, 9 months ago (2015-02-27 15:28:37 UTC) #2
reed1
lgtm
5 years, 9 months ago (2015-02-27 16:19:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967553003/1
5 years, 9 months ago (2015-02-27 16:21:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/2308)
5 years, 9 months ago (2015-02-27 16:22:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967553003/20001
5 years, 9 months ago (2015-02-27 16:25:31 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 16:32:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a9061de9ff8d5b9545e5d1ef7a6e4054e1907c95

Powered by Google App Engine
This is Rietveld 408576698