Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Unified Diff: Source/core/layout/svg/LayoutSVGResourceMasker.h

Issue 967543002: [S.P.] Move svg mask painting to SVGMaskPainter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: move drawMaskForRenderer too Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/svg/LayoutSVGResourceMasker.h
diff --git a/Source/core/layout/svg/LayoutSVGResourceMasker.h b/Source/core/layout/svg/LayoutSVGResourceMasker.h
index bbe482657fbabc7d18d3bf48729c6f68a92e324e..434be4a0d7272217483d9e66ca889d5d7cf3054e 100644
--- a/Source/core/layout/svg/LayoutSVGResourceMasker.h
+++ b/Source/core/layout/svg/LayoutSVGResourceMasker.h
@@ -46,9 +46,6 @@ public:
virtual void removeAllClientsFromCache(bool markForInvalidation = true) override;
virtual void removeClientFromCache(LayoutObject*, bool markForInvalidation = true) override;
- bool prepareEffect(LayoutObject*, GraphicsContext*);
- void finishEffect(LayoutObject*, GraphicsContext*);
-
FloatRect resourceBoundingBox(const LayoutObject*);
SVGUnitTypes::SVGUnitType maskUnits() const { return toSVGMaskElement(element())->maskUnits()->currentValue()->enumValue(); }
@@ -58,8 +55,8 @@ public:
virtual LayoutSVGResourceType resourceType() const override { return s_resourceType; }
private:
+ friend class SVGMaskPainter;
fs 2015/03/02 13:24:51 With the suggestion in SVGMaskPainter I don't thin
Erik Dahlström (inactive) 2015/03/03 08:42:58 Done.
void calculateMaskContentPaintInvalidationRect();
- void drawMaskForRenderer(GraphicsContext*, DisplayItemClient, const FloatRect& targetBoundingBox);
PassRefPtr<const SkPicture> createContentPicture();
RefPtr<const SkPicture> m_maskContentPicture;

Powered by Google App Engine
This is Rietveld 408576698