chrome/browser/autocomplete/zero_suggest_provider.cc - Issue 96753004: Ensure zero suggest can handle XSSI-escaped output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider.cc

Issue 96753004: Ensure zero suggest can handle XSSI-escaped output. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing the return value in failure case Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/zero_suggest_provider.cc

diff --git a/chrome/browser/autocomplete/zero_suggest_provider.cc b/chrome/browser/autocomplete/zero_suggest_provider.cc

index 07d7c2c6ebacfcd7e34db58544981648fd5c9732..7207fd8646b984f80c2fde876b838fe79cd501db 100644

--- a/chrome/browser/autocomplete/zero_suggest_provider.cc

+++ b/chrome/browser/autocomplete/zero_suggest_provider.cc

@@ -133,9 +133,7 @@ void ZeroSuggestProvider::OnURLFetchComplete(const net::URLFetcher* source) {

source->GetStatus().is_success() && source->GetResponseCode() == 200;

if (request_succeeded) {

- JSONStringValueSerializer deserializer(json_data);

- deserializer.set_allow_trailing_comma(true);

- scoped_ptr<Value> data(deserializer.Deserialize(NULL, NULL));

+ scoped_ptr<Value> data(SearchProvider::DeserializeJsonData(json_data));

if (data.get())

ParseSuggestResults(*data.get());

}