Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 96753004: Ensure zero suggest can handle XSSI-escaped output. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update CL to share json parsing code Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index e8c07d5f7b1e5133048c686a6ffa6f2139f52b24..4179a27ffb7ecaa2e876844b77a88fef49a2c75e 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -410,6 +410,11 @@ class SearchProvider : public AutocompleteProvider,
const TemplateURL* template_url,
const AutocompleteInput& input);
+ // Attempts to parse JSON response received from the provider stripping XSSI
Mark P 2013/12/02 22:32:19 nit: Attempts to parse -> Parses (the attempting i
H Fung 2013/12/02 23:04:52 comma after "provider"?
Maria 2013/12/02 23:24:29 Done.
Maria 2013/12/02 23:24:29 Done.
+ // protection if needed. Returns the parsed data, if successful, NULL
Mark P 2013/12/02 22:32:19 nit: no comma before "if successful"
Maria 2013/12/02 23:24:29 Done.
+ // otherwise.
+ static scoped_ptr<base::Value> DeserializeJsonData(std::string json_data);
+
// Parses results from the suggest server and updates the appropriate suggest
// and navigation result lists, depending on whether |is_keyword| is true.
// Returns whether the appropriate result list members were updated.
« no previous file with comments | « no previous file | chrome/browser/autocomplete/search_provider.cc » ('j') | chrome/browser/autocomplete/search_provider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698