Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 96753003: Remove the obsolete Code::IsPregenerated flag. (Closed)

Created:
7 years ago by Benedikt Meurer
Modified:
7 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Remove the obsolete Code::IsPregenerated flag. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18172

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment about unused bit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -55 lines) Patch
M src/arm/code-stubs-arm.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M src/objects.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Another lovely one, freeing another bit in Code::Flags! PTAL -- Benedikt
7 years ago (2013-11-29 21:04:08 UTC) #1
Michael Starzinger
LGTM if one comment is addressed. https://codereview.chromium.org/96753003/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/96753003/diff/1/src/objects.h#newcode5449 src/objects.h:5449: class ExtraICStateField: public ...
7 years ago (2013-12-02 09:21:29 UTC) #2
Benedikt Meurer
Committed patchset #2 manually as r18172.
7 years ago (2013-12-02 09:46:44 UTC) #3
Benedikt Meurer
7 years ago (2013-12-02 09:47:50 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/96753003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/96753003/diff/1/src/objects.h#newcode5449
src/objects.h:5449: class ExtraICStateField: public BitField<ExtraICState, 11,
6> {};
On 2013/12/02 09:21:30, Michael Starzinger wrote:
> Can we reorder the following fields to start at bit 10? Otherwise we will
never
> find this free bit again.

That'll break some assertions. I'll add a comment instead.

Powered by Google App Engine
This is Rietveld 408576698