Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 967523002: Revert of Web Animations: Remove AnimationPlayer discarding logic (Closed)

Created:
5 years, 9 months ago by Mike West
Modified:
5 years, 9 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Web Animations: Remove AnimationPlayer discarding logic (patchset #2 id:20001 of https://codereview.chromium.org/955303002/) Reason for revert: It looks like this patch broke `webkit_unit_tests` (`WebFrameSwapTest.SwapPreservesGlobalContext` in particular) on a number of platforms. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/44832 for example. Original issue's description: > Web Animations: Remove AnimationPlayer discarding logic > > Since forwards filling animations are supposed to be returned via > getAnimationPlayers, we can no longer discard them when we've dropped > references to them. This patch removes this discarding logic. > > BUG=439247 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190977 TBR=dstockwell@chromium.org,samli@chromium.org,timloh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=439247 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -1 line) Patch
M Source/core/animation/Animation.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/Animation.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationStack.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationStack.cpp View 2 chunks +27 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationStackTest.cpp View 1 chunk +34 lines, -0 lines 0 comments Download
M Source/core/animation/SampledEffect.h View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/animation/SampledEffect.cpp View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
Created Revert of Web Animations: Remove AnimationPlayer discarding logic
5 years, 9 months ago (2015-02-27 10:46:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967523002/1
5 years, 9 months ago (2015-02-27 10:46:48 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 10:47:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190983

Powered by Google App Engine
This is Rietveld 408576698