Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: Source/devtools/front_end/promises/PromisePane.js

Issue 967493002: DevTools: remove setLastEvaluationResult from the protocol. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorConsoleAgent.cpp ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/promises/PromisePane.js
diff --git a/Source/devtools/front_end/promises/PromisePane.js b/Source/devtools/front_end/promises/PromisePane.js
index a01aff38acc5e9d7dd99284db3f5aeaa30509705..7612c97dd0d2d08e1a66721b75d9a4190282426d 100644
--- a/Source/devtools/front_end/promises/PromisePane.js
+++ b/Source/devtools/front_end/promises/PromisePane.js
@@ -463,19 +463,17 @@ WebInspector.PromisePane.prototype = {
{
if (error || !promise)
return;
-
- target.consoleAgent().setLastEvaluationResult(promise.objectId);
- var message = new WebInspector.ConsoleMessage(target,
- WebInspector.ConsoleMessage.MessageSource.Other,
- WebInspector.ConsoleMessage.MessageLevel.Log,
- "",
- WebInspector.ConsoleMessage.MessageType.Log,
- undefined,
- undefined,
- undefined,
- undefined,
- [promise]);
- target.consoleModel.addMessage(message);
+ var object = target.runtimeModel.createRemoteObject(promise);
+ object.callFunction(dumpIntoConsole);
+ object.release();
+ /**
+ * @suppressReceiverCheck
+ * @this {Object}
+ */
+ function dumpIntoConsole()
+ {
+ console.log(this);
+ }
WebInspector.console.show();
}
},
« no previous file with comments | « Source/core/inspector/InspectorConsoleAgent.cpp ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698