Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Unified Diff: Source/devtools/front_end/promises/PromisePane.js

Issue 967493002: DevTools: remove setLastEvaluationResult from the protocol. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/promises/PromisePane.js
diff --git a/Source/devtools/front_end/promises/PromisePane.js b/Source/devtools/front_end/promises/PromisePane.js
index 745e7915434bf2042872657a65550db1260076e4..695d2706f84e6c34ca10b22912c88d490612c6ab 100644
--- a/Source/devtools/front_end/promises/PromisePane.js
+++ b/Source/devtools/front_end/promises/PromisePane.js
@@ -481,19 +481,17 @@ WebInspector.PromisePane.prototype = {
{
if (error || !promise)
return;
-
- target.consoleAgent().setLastEvaluationResult(promise.objectId);
- var message = new WebInspector.ConsoleMessage(target,
- WebInspector.ConsoleMessage.MessageSource.Other,
- WebInspector.ConsoleMessage.MessageLevel.Log,
- "",
- WebInspector.ConsoleMessage.MessageType.Log,
- undefined,
- undefined,
- undefined,
- undefined,
- [promise]);
- target.consoleModel.addMessage(message);
+ var object = target.runtimeModel.createRemoteObject(promise);
+ object.callFunction(dumpIntoConsole);
+ object.release();
+ /**
+ * @suppressReceiverCheck
+ * @this {Object}
+ */
+ function dumpIntoConsole()
+ {
+ console.log(this);
aandrey 2015/02/27 08:01:54 This should be tested, maybe? e.g. now there will
pfeldman 2015/02/27 08:05:34 No, console.log does not dump any stacks.
+ }
WebInspector.console.show();
}
},

Powered by Google App Engine
This is Rietveld 408576698