Chromium Code Reviews Chromium Code Reviews
Issue 967493002:
DevTools: remove setLastEvaluationResult from the protocol. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| 1 <html> | 1 <html> |
| 2 <head> | 2 <head> |
| 3 <script src="../../http/tests/inspector/inspector-test.js"></script> | 3 <script src="../../http/tests/inspector/inspector-test.js"></script> |
| 4 <script src="../../http/tests/inspector/console-test.js"></script> | 4 <script src="../../http/tests/inspector/console-test.js"></script> |
| 5 <script> | 5 <script> |
| 6 | 6 |
| 7 var obj = { "a" : 1, "b": 2 }; | 7 var obj = { "a" : 1, "b": 2 }; |
| 8 | 8 |
| 9 function test() | 9 function test() |
| 10 { | 10 { |
| 11 var remote; | 11 var remote; |
| 12 InspectorTest.RuntimeAgent.evaluate("window.obj", step1); | 12 InspectorTest.RuntimeAgent.evaluate("window.obj", step1); |
| 13 | 13 |
| 14 function step1(error, result) | 14 function step1(error, result) |
| 15 { | 15 { |
| 16 InspectorTest.assertTrue(!error, "FAIL: " + error); | 16 InspectorTest.assertTrue(!error, "FAIL: " + error); |
| 17 remote = result; | 17 remote = result; |
|
dgozman
2015/02/27 07:56:56
This one is no longer used.
pfeldman
2015/02/27 08:00:20
Done.
| |
| 18 InspectorTest.evaluateInConsole("1+1", step2); | 18 InspectorTest.evaluateInConsole("1+1", step2); |
| 19 } | 19 } |
| 20 | 20 |
| 21 function step2() | 21 function step2() |
| 22 { | 22 { |
| 23 InspectorTest.evaluateInConsole("$_", step3); | |
| 24 } | |
| 25 | |
| 26 function step3() | |
| 27 { | |
| 28 InspectorTest.ConsoleAgent.setLastEvaluationResult(remote.objectId, didS etResult); | |
| 29 } | |
| 30 | |
| 31 function didSetResult(error) | |
| 32 { | |
| 33 InspectorTest.assertTrue(!error, "FAIL: " + error); | |
| 34 InspectorTest.evaluateInConsole("$_", completeTest); | 23 InspectorTest.evaluateInConsole("$_", completeTest); |
|
dgozman
2015/02/27 07:56:56
It seems this test no longer tests anything. Remov
pfeldman
2015/02/27 08:00:20
What do you mean? This is the essence of this test
aandrey
2015/02/27 08:01:54
+1 to remove the test
dgozman
2015/02/27 08:03:22
This is now a subset of inspector/console/console-
aandrey
2015/02/27 08:03:46
The "essence" is tested in inspector/console/conso
pfeldman
2015/02/27 08:05:34
Done.
| |
| 35 } | 24 } |
| 36 | 25 |
| 37 function completeTest() | 26 function completeTest() |
| 38 { | 27 { |
| 39 InspectorTest.dumpConsoleMessages(); | 28 InspectorTest.dumpConsoleMessages(); |
| 40 InspectorTest.completeTest(); | 29 InspectorTest.completeTest(); |
| 41 } | 30 } |
| 42 } | 31 } |
| 43 | 32 |
| 44 </script> | 33 </script> |
| 45 </head> | 34 </head> |
| 46 | 35 |
| 47 <body onload="runTest()"> | 36 <body onload="runTest()"> |
| 48 <p> | 37 <p> |
| 49 Tests setting console last evaluation result. | 38 Tests setting console last evaluation result. |
| 50 </p> | 39 </p> |
| 51 </body> | 40 </body> |
| 52 </html> | 41 </html> |
| OLD | NEW |
