Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/isolate.h

Issue 967483003: Remove obsolete Isolate::DoThrow helper. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix one comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ISOLATE_H_ 5 #ifndef V8_ISOLATE_H_
6 #define V8_ISOLATE_H_ 6 #define V8_ISOLATE_H_
7 7
8 #include <queue> 8 #include <queue>
9 #include "include/v8-debug.h" 9 #include "include/v8-debug.h"
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 762 matching lines...) Expand 10 before | Expand all | Expand 10 after
773 void RestorePendingMessageFromTryCatch(v8::TryCatch* handler); 773 void RestorePendingMessageFromTryCatch(v8::TryCatch* handler);
774 // Un-schedule an exception that was caught by a TryCatch handler. 774 // Un-schedule an exception that was caught by a TryCatch handler.
775 void CancelScheduledExceptionFromTryCatch(v8::TryCatch* handler); 775 void CancelScheduledExceptionFromTryCatch(v8::TryCatch* handler);
776 void ReportPendingMessages(); 776 void ReportPendingMessages();
777 // Return pending location if any or unfilled structure. 777 // Return pending location if any or unfilled structure.
778 MessageLocation GetMessageLocation(); 778 MessageLocation GetMessageLocation();
779 Object* ThrowIllegalOperation(); 779 Object* ThrowIllegalOperation();
780 780
781 // Promote a scheduled exception to pending. Asserts has_scheduled_exception. 781 // Promote a scheduled exception to pending. Asserts has_scheduled_exception.
782 Object* PromoteScheduledException(); 782 Object* PromoteScheduledException();
783 void DoThrow(Object* exception, MessageLocation* location);
784 // Checks if exception should be reported and finds out if it's 783 // Checks if exception should be reported and finds out if it's
785 // caught externally. 784 // caught externally.
786 bool ShouldReportException(bool* can_be_caught_externally, 785 bool ShouldReportException(bool* can_be_caught_externally,
787 bool catchable_by_javascript); 786 bool catchable_by_javascript);
788 787
789 // Attempts to compute the current source location, storing the 788 // Attempts to compute the current source location, storing the
790 // result in the target out parameter. 789 // result in the target out parameter.
791 void ComputeLocation(MessageLocation* target); 790 void ComputeLocation(MessageLocation* target);
792 bool ComputeLocationFromException(MessageLocation* target, 791 bool ComputeLocationFromException(MessageLocation* target,
793 Handle<Object> exception); 792 Handle<Object> exception);
(...skipping 776 matching lines...) Expand 10 before | Expand all | Expand 10 after
1570 } 1569 }
1571 1570
1572 EmbeddedVector<char, 128> filename_; 1571 EmbeddedVector<char, 128> filename_;
1573 FILE* file_; 1572 FILE* file_;
1574 int scope_depth_; 1573 int scope_depth_;
1575 }; 1574 };
1576 1575
1577 } } // namespace v8::internal 1576 } } // namespace v8::internal
1578 1577
1579 #endif // V8_ISOLATE_H_ 1578 #endif // V8_ISOLATE_H_
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698