Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 967483003: Remove obsolete Isolate::DoThrow helper. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete Isolate::DoThrow helper. R=bmeurer@chromium.org Committed: https://crrev.com/627ffe9af217e413f878bc025dbcf282dd709151 Cr-Commit-Position: refs/heads/master@{#26913}

Patch Set 1 #

Patch Set 2 : Fix one comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -126 lines) Patch
M src/api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 5 chunks +124 lines, -124 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
Pure refactoring. No functional changes.
5 years, 9 months ago (2015-02-27 09:56:13 UTC) #1
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-02-27 09:57:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967483003/20001
5 years, 9 months ago (2015-02-27 10:52:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-27 11:15:41 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 11:15:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/627ffe9af217e413f878bc025dbcf282dd709151
Cr-Commit-Position: refs/heads/master@{#26913}

Powered by Google App Engine
This is Rietveld 408576698