Stop defaulting unrecognized branches to master except for handful of special refs

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 from distutils.version import LooseVersion
@@ skipping 38 matching lines @@
 import subprocess2
 import watchlists
 
 __version__ = '1.0'
 
 DEFAULT_SERVER = 'https://codereview.appspot.com'
 POSTUPSTREAM_HOOK_PATTERN = '.git/hooks/post-cl-%s'
 DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
 GIT_INSTRUCTIONS_URL = 'http://code.google.com/p/chromium/wiki/UsingGit'
 CHANGE_ID = 'Change-Id:'
+REFS_THAT_DEFAULT_TO_MASTER = ('refs/remotes/origin/lkgr',

[agable, 2015/03/02 23:11:34]

It might make more sense to have a REFS_THAT_ALIAS_TO_OTHER_REFS map, which maps
lkgr and lkcr to master. Not sure if you want to go the general route for
forwards-compatibility, or use this highly specific route to prevent other
people from abusing the mechanism. Either is fine by me.

[rmistry, 2015/03/03 12:26:23]

Lets try the general route for forwards-compatibility. Done.

+                               'refs/remotes/origin/lkcr')
 
 # Valid extensions for files we want to lint.
 DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
 DEFAULT_LINT_IGNORE_REGEX = r"$^"
 
 # Shortcut since it quickly becomes redundant.
 Fore = colorama.Fore
 
 # Initialized in main()
 settings = None
@@ skipping 1714 matching lines @@
       )
       match = None
       for regex, replacement in prefix_replacements:
         match = re.search(regex, target_branch)
         if match:
           remote_branch = target_branch.replace(match.group(0), replacement)
           break
       if not match:
         # This is a branch path but not one we recognize; use as-is.
         remote_branch = target_branch
-  elif (not remote_branch.startswith('refs/remotes/branch-heads') and
-        not remote_branch.startswith('refs/remotes/%s/refs' % remote)):
-    # Default to master for refs that are not branches.
+  elif remote_branch in REFS_THAT_DEFAULT_TO_MASTER:
+    # Handle the special refs that should land in master.
     remote_branch = 'refs/remotes/%s/master' % remote
 
   # Create the true path to the remote branch.
   # Does the following translation:
   # * refs/remotes/origin/refs/diff/test -> refs/diff/test
   # * refs/remotes/origin/master -> refs/heads/master
   # * refs/remotes/branch-heads/test -> refs/branch-heads/test
   if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
     remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
   elif remote_branch.startswith('refs/remotes/%s/' % remote):
@@ skipping 1288 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   colorama.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)