Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 967453002: Revert of Wait until a new profile has been created before deleting the active profile. (Closed)

Created:
5 years, 9 months ago by qyearsley
Modified:
5 years, 9 months ago
CC:
chromium-reviews, rginda+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Wait until a new profile has been created before deleting the active profile. (patchset #6 id:100001 of https://codereview.chromium.org/953453002/) Reason for revert: Suspected of causing flaky failure of ProfileManagerBrowserTests.DeleteSingletonProfile and ProfileManagerBrowserTests.DeletePasswords on Mac. Examples: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/4785 https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/4789 https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/4790 http://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/4858 http://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/4859 http://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/4860 Original issue's description: > Wait until a new profile has been created before deleting the active profile. > > BUG=460859 > > Committed: https://crrev.com/944361e0a8808cc0c82dcb0ef4e58440f5d1c0fa > Cr-Commit-Position: refs/heads/master@{#318288} TBR=noms@chromium.org,rsesek@chromium.org,bauerb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460859 Committed: https://crrev.com/ad6fc4c62819eda0b60bde00fe4fedd415a74fab Cr-Commit-Position: refs/heads/master@{#318376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -61 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 6 chunks +58 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qyearsley
Created Revert of Wait until a new profile has been created before deleting the active ...
5 years, 9 months ago (2015-02-27 01:50:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967453002/1
5 years, 9 months ago (2015-02-27 01:50:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 01:51:52 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 01:52:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad6fc4c62819eda0b60bde00fe4fedd415a74fab
Cr-Commit-Position: refs/heads/master@{#318376}

Powered by Google App Engine
This is Rietveld 408576698