pylib/gyp/generator/ninja.py - Issue 967443002: Assert when source is an absoluth path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/ninja.py

Issue 967443002: Assert when source is an absoluth path (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Resubmit using gyp repo Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/generator/ninja.py

diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py

index 587bf32f0097afa17549a4801a0bdf042f5cf270..0853ab012438a8300daf6ee81da324602d36353b 100644

--- a/pylib/gyp/generator/ninja.py

+++ b/pylib/gyp/generator/ninja.py

@@ -340,6 +340,9 @@ class NinjaWriter(object):

obj += '.' + self.toolset

path_dir, path_basename = os.path.split(path)

+ assert not os.path.isabs(path_dir), (

+ "'%s' can not be absolute path (see crbug.com/462153)." % path_dir)

if qualified:

path_basename = self.name + '.' + path_basename

return os.path.normpath(os.path.join(obj, self.base_dir, path_dir,

« no previous file with comments | « no previous file | no next file » | no next file with comments »