Issue 96743003: Fix JS interface for synthetic smooth scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 96743003: Fix JS interface for synthetic smooth scroll. (Closed)

Created:
7 years ago by Dominik Grewe

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix JS interface for synthetic smooth scroll. We recently renamed the starting coordinates of a synthetic smooth scroll from mouse_event_{x,y} to start_{x,y}. However, some uses of these variables have not been renamed accordingly. This patch fixes that. BUG=297980 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238076

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	content/renderer/gpu/gpu_benchmarking_extension.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dominik Grewe

Jochen, can you please have a look as owner of content/? The owners of content/renderer/ ...

7 years ago (2013-11-29 11:12:07 UTC) #1

jochen (gone - plz use gerrit)

lgtm please update the CL description so the BUG= line points to the proper bug ...

7 years ago (2013-12-02 10:38:52 UTC) #2

Dominik Grewe

On 2013/12/02 10:38:52, jochen wrote: > lgtm > > please update the CL description so ...

7 years ago (2013-12-02 10:44:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/96743003/1

7 years ago (2013-12-02 10:44:55 UTC) #4

Message was sent while issue was closed.

Change committed as 238076

Expand Messages | Collapse Messages