Issue 96743002: Revert r18144, r18143.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 96743002: Revert r18144, r18143. (Closed)

Created:
7 years ago by Yang

Modified:
7 years ago

Reviewers:
palfia

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert r18144, r18143. MIPS: Fix register usage. MIPS: Cleanup in the CallStubCompiler. The original revisions r18131 and r18139 have been reverted. TBR=palfia@homejinni.com Committed: https://code.google.com/p/v8/source/detail?r=18154

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -64 lines)			Patch
M	src/mips/macro-assembler-mips.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	3 chunks	+2 lines, -15 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	17 chunks	+117 lines, -42 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2013/11/29 10:31:55, Yang wrote: > Committed patchset #1 manually as r18154 (presubmit successful). Btw. ...

7 years ago (2013-11-29 10:33:41 UTC) #3

palfia

On 2013/11/29 10:33:41, Yang wrote: > On 2013/11/29 10:31:55, Yang wrote: > > Committed patchset ...

7 years ago (2013-11-29 12:17:42 UTC) #4

Yang

7 years ago (2013-11-29 12:21:12 UTC) #5

Message was sent while issue was closed.

On 2013/11/29 12:17:42, palfia wrote:
> On 2013/11/29 10:33:41, Yang wrote:
> > On 2013/11/29 10:31:55, Yang wrote:
> > > Committed patchset #1 manually as r18154 (presubmit successful).
> > 
> > Btw. we enabled new_string_add in flag-definitions.h by default. And it
looks
> > like MIPS is having trouble at mksnapshot.
> 
> Thanks for pointing this out! I'm working on a fix for this problem.

We disabled new_string_add for some other reason again, but the MIPS issue also
needs to be fixed. Thanks!

Expand Messages | Collapse Messages