Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: Source/core/page/CreateWindow.cpp

Issue 967423005: <iframe sandbox> should inherit through <a target='_blank'>. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Ugh. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/security/sandbox-inherit-to-blank-document.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/CreateWindow.cpp
diff --git a/Source/core/page/CreateWindow.cpp b/Source/core/page/CreateWindow.cpp
index 843fc437528b1b72bedde92699a56b613192e641..b3b2cdd598b3e961346b978b369e6f926e1bf575 100644
--- a/Source/core/page/CreateWindow.cpp
+++ b/Source/core/page/CreateWindow.cpp
@@ -118,6 +118,8 @@ static LocalFrame* createWindow(LocalFrame& openerFrame, LocalFrame& lookupFrame
host->chrome().setWindowRect(newWindowRect);
host->chrome().show(policy);
+ frame.loader().forceSandboxFlags(openerFrame.document()->sandboxFlags());
+
created = true;
return &frame;
}
@@ -151,9 +153,6 @@ LocalFrame* createWindow(const String& urlString, const AtomicString& frameName,
if (!newFrame)
return nullptr;
- if (newFrame != &openerFrame && newFrame != openerFrame.tree().top())
- newFrame->loader().forceSandboxFlags(openerFrame.document()->sandboxFlags());
-
newFrame->loader().setOpener(&openerFrame);
if (newFrame->localDOMWindow()->isInsecureScriptAccess(callingWindow, completedURL))
« no previous file with comments | « LayoutTests/http/tests/security/sandbox-inherit-to-blank-document.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698