Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 967403005: Add event trace to DispatchEvent on ozone (Closed)

Created:
5 years, 9 months ago by oshima
Modified:
5 years, 9 months ago
Reviewers:
sadrul, spang
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add event trace to DispatchEvent on ozone BUG=450711 Committed: https://crrev.com/c6bd676c378ce64beaf120c94b3aad886818cf7c Cr-Commit-Position: refs/heads/master@{#318950}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/aura/window_tree_host_ozone.cc View 2 chunks +2 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (6 generated)
oshima
5 years, 9 months ago (2015-03-03 20:13:41 UTC) #5
sadrul
LGTM
5 years, 9 months ago (2015-03-03 20:23:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967403005/60001
5 years, 9 months ago (2015-03-03 22:07:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 9 months ago (2015-03-03 22:17:50 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c6bd676c378ce64beaf120c94b3aad886818cf7c Cr-Commit-Position: refs/heads/master@{#318950}
5 years, 9 months ago (2015-03-03 22:18:31 UTC) #10
spang
https://codereview.chromium.org/967403005/diff/60001/ui/aura/window_tree_host_ozone.cc File ui/aura/window_tree_host_ozone.cc (left): https://codereview.chromium.org/967403005/diff/60001/ui/aura/window_tree_host_ozone.cc#oldcode83 ui/aura/window_tree_host_ozone.cc:83: void WindowTreeHostOzone::DispatchEvent(ui::Event* event) { FYI ash overrides this function. ...
5 years, 9 months ago (2015-03-04 00:14:05 UTC) #12
oshima
5 years, 9 months ago (2015-03-04 00:56:38 UTC) #13
Message was sent while issue was closed. 
On 2015/03/04 00:14:05, spang wrote:
>
https://codereview.chromium.org/967403005/diff/60001/ui/aura/window_tree_host...
> File ui/aura/window_tree_host_ozone.cc (left):
> 
>
https://codereview.chromium.org/967403005/diff/60001/ui/aura/window_tree_host...
> ui/aura/window_tree_host_ozone.cc:83: void
> WindowTreeHostOzone::DispatchEvent(ui::Event* event) {
> FYI
> 
> ash overrides this function. It will not be called with ash.

Doh, thanks for the catch. I'll update the ash too.

Powered by Google App Engine
This is Rietveld 408576698