Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 967393002: [Extensions] Update chrome://extensions to use developerPrivate.allowFileAccess (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Update chrome://extensions to use developerPrivate.allowFileAccess BUG=461039 BUG=463082 Committed: https://crrev.com/2f08432c2408c46e2c951471add6384021ee997a Cr-Commit-Position: refs/heads/master@{#318746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/resources/extensions/extension_list.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Devlin
D'oh.
5 years, 9 months ago (2015-03-02 19:08:03 UTC) #2
not at google - send to devlin
This is it? There's no accompanying deletion of other code?
5 years, 9 months ago (2015-03-02 19:30:16 UTC) #3
not at google - send to devlin
Ok, "d'oh", I can guess why. Lgtm.
5 years, 9 months ago (2015-03-02 19:30:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967393002/1
5 years, 9 months ago (2015-03-02 19:31:29 UTC) #6
Devlin
On 2015/03/02 19:30:32, kalman wrote: > Ok, "d'oh", I can guess why. Lgtm. Yeah, https://codereview.chromium.org/954943007/ ...
5 years, 9 months ago (2015-03-02 19:31:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 21:02:13 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 21:03:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f08432c2408c46e2c951471add6384021ee997a
Cr-Commit-Position: refs/heads/master@{#318746}

Powered by Google App Engine
This is Rietveld 408576698